On Mon, 2 Mar 2026 13:03:19 GMT, Daniel Jeliński <[email protected]> wrote:
>> Jasmine Karthikeyan has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains three
>> additional commits since the last revision:
>>
>> - Apply review changes
>> - Merge branch 'master' into fix-8378180
>> - Fix discarded const qualifiers
>
> src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c line 230:
>
>> 228:
>> 229: static int initDebPackage(void* desc, const char* str) {
>> 230: char* colonChrPos = (char*) strchr(str, ':');
>
> `str` should really be `char*` instead; it's modified in line 232 below. Once
> you change `str`'s type, you will no longer need a cast here.
>
> You'll also need to modify the `popenCallbackType` type to remove `const`.
Thanks for the suggestion! I had to change the const in a few other places that
`popenCallbackType` was used as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29929#discussion_r3070275051
