On Sun, 12 Apr 2026 22:46:20 GMT, Jasmine Karthikeyan <[email protected]> wrote:
>> Hi all, this is a quick patch to fix a build issue I encountered when >> updating my Linux system. [Glibc >> 2.43](https://lists.gnu.org/archive/html/info-gnu/2026-01/msg00005.html) >> changes the definition of some string related functions to return `const >> char*` when provided a `const char*` parameter, rather than the previous >> behavior of returning `char*`. I've fixed this by applying the `const` >> modifier, and casting to `char*` when needed. This should be >> backwards-compatible since assigning a non-const pointer to const is an >> implicit conversion. Thoughts and comments would be appreciated on whether >> this is the best way to fix this issue. Thanks! >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jasmine Karthikeyan has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Apply review changes > - Merge branch 'master' into fix-8378180 > - Fix discarded const qualifiers LGTM ------------- Marked as reviewed by djelinski (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29929#pullrequestreview-4096460661
