On Fri, 17 Apr 2026 06:30:05 GMT, Serguei Spitsyn <[email protected]> wrote:
>> The another difference observed by @sspitsyn while discussing this issue. >> The remove_dead_entries_locked() is now called and work even if >> ` env()->is_enabled(JVMTI_EVENT_OBJECT_FREE)` >> is false. >> It just cleans up tagmap table, but doesn't post events. Shouldn't change >> behaviour observed by jvmti agent. >> The performance impact is not significant comparing with heap walking. > > One more difference that the `check_hashmaps_for_heapwalk()` is also called > when `objects == nullptr`. check_hashmaps_for_heapwalk() never called with objects == nullptr The goal of this function is to post ObjectFree events. I still wonder why is it needed? It collect tags for dead objects before heap walking and post them right after corresponding VMOp is completed. It is really unclear for me if there are any reasons to do this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30757#discussion_r3101226158
