On Wed, 22 Apr 2026 11:55:06 GMT, David Holmes <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove mention of -Xverify:none from the java launcher help text
>
> src/java.base/share/native/libjli/java.c line 1308:
>
>> 1306: } else if (JLI_StrCmp(arg, "-verify") == 0) {
>> 1307: JLI_ReportErrorMessage(ARG_DEPRECATED, "-verify");
>> 1308: AddOption("-Xverify:all", NULL);
>
> Is this deprecated flag going to be handled separately?
Yes, my initial idea (a few months back) was to remove `-verify` option as part
of this activity, but I decided to leave this one around for at least one more
release for the reason I note in the JBS issue
https://bugs.openjdk.org/browse/JDK-8373481?focusedId=14840775&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14840775
> test/hotspot/jtreg/gc/shenandoah/compiler/CallMultipleCatchProjs.java line 30:
>
>> 28: * @requires vm.gc.Shenandoah
>> 29: *
>> 30: * @run main/othervm -XX:CompileOnly=CallMultipleCatchProjs::test -Xcomp
>> -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC CallMultipleCatchProjs
>
> Does the test not actually require that verification be disabled?
I am not familiar with this test, so I'll need inputs on this test change (the
PR description has details about this part).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30877#discussion_r3123768261
PR Review Comment: https://git.openjdk.org/jdk/pull/30877#discussion_r3123774285
