On Fri, 24 Apr 2026 19:22:22 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: (1) remove unneeded assert, (2) simplify one statement in
>> JvmtiEnvBase::set_frame_pop
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2506:
>
>> 2504: }
>> 2505: if (!_set) { // ClearAllFramePops
>> 2506: _state->clear_vthread_pending_deopts();
>
> The state is cleared always, even there are some other jvmti environments
> still set FramePops. They are going to miss the events.
>
> Seems the clear_vthread_pending_deopts() should be called based on the status
> of FramePop for all environments.
Thank you for checking. Only one JVMTI environment can enable debugging
features including `FramePop` events. So, this is not a problem if I do not
miss anything.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3140266521
