On Fri, 24 Apr 2026 20:30:19 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: (1) remove unneeded assert, (2) simplify one statement in >> JvmtiEnvBase::set_frame_pop > > src/hotspot/share/prims/jvmtiEnvBase.cpp line 1366: > >> 1364: return JVMTI_ERROR_DUPLICATE; >> 1365: } >> 1366: ets->set_frame_pop(frame_number); > > Shouldn't be moved into line 1375 to don't set_frame_pop() if > JVMTI_ERROR_OPAQUE_FRAME is returned? Good catch, thanks. I'll try to move it to the and of function just before `return JVMTI_ERROR_NONE`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28407#discussion_r3141549233
