On Fri, 24 Apr 2026 18:32:52 GMT, Chris Plummer <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 1. Fix the comments about the senond attemt trigger finalize(); 2. >> Replaced finalizerRun as FINALIZER_DONE.getCount() > > test/jdk/com/sun/jdi/FinalizerTest.java line 110: > >> 108: System.runFinalization(); >> 109: } >> 110: return; > > If I'm understanding the logic here properly, if for some reason > waitForAFinalizer() never triiggers finalization, it will eventually exit > here, and the only real sign that something went wrong is the debugger side > of the test timing out because it does not get a breakpoint event in the > finalizer. Maybe we should at least have a println here to indicate that the > finalizer was never triggered. I think you are right. I have added a println before return waitForAFinalizer. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30829#discussion_r3141436665
