> This change fixes a long standing performance issue related to the debugger > single stepping that is using JVMTI `FramePop` events as a part of step over > handling. The performance issue is that the target thread continues its > execution in very slow `interp-only` mode in a context of frame marked for > `FramePop` notification with the JVMTI `NotifyFramePop`. It includes other > method calls recursively upon a return from the frame. > > This fix is to avoid enforcing the `interp-only` execution mode for threads > when `FramePop` events are enabled with the JVMTI > `SetEventNotificationMode()`. Instead, the target frame has been deoptimized > and kept interpreted by disabling `OSR` optimization by the function > `InterpreterRuntime::frequency_counter_overflow_inner()`. (Big thanks to > @fisk for this suggestion!) Additionally, some tweaks are applied in several > places where the `java_thread->is_interp_only_mode()` is checked. > The other details will be provided in the first PR request comment. > > Testing: > - test `serviceability/jvmti/vthread/ThreadStateTest` was updated to provide > some extra test coverage > - submitted mach5 tiers 1-6 > > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision: review: 1. move set_frame_pop call; 2. decrease test execution time and its timeout ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28407/files - new: https://git.openjdk.org/jdk/pull/28407/files/f15d8817..4be0eb8a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28407&range=23 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28407&range=22-23 Stats: 6 lines in 2 files changed: 1 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/28407.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28407/head:pull/28407 PR: https://git.openjdk.org/jdk/pull/28407
