On Wed, 29 Apr 2026 08:13:47 GMT, Serguei Spitsyn <[email protected]> wrote:

>> David Holmes has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use std::atomic for shared variables
>
> I like the fix in general. It is simple and reasonable. Still need to review 
> new test and make a second pass.

Thanks for looking at this @sspitsyn !

> src/hotspot/share/prims/jni.cpp line 2839:
> 
>> 2837: 
>> 2838:   // We must defer JVM TI suspension while we have access to a Java 
>> object
>> 2839:   // as it could suprise the debugger if we mutate it concurrently 
>> whilst
> 
> Q: I guess, the word `suprise` was used intentionally instead of `surprise`.

Just a typo. Thanks

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30936#issuecomment-4349280357
PR Review Comment: https://git.openjdk.org/jdk/pull/30936#discussion_r3165306388

Reply via email to