On Wed, 29 Apr 2026 19:21:00 GMT, Leonid Mesnik <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix library tag placement, revert NormalMapping, add @key randomness to
>> parent tests
>
> The changes look good.
> If you make an incorrect commit, it is needed to just revert it by committing
> anti-delta and not rebasing the branch.
> @lmesnik can you say more about the 'randomness' key and how it is actually
> used? I'm not aware of any actual usage via jtreg so is this just a
> documentation aid?
I had seen this `@key randomness` being used before but I too wasn't aware why
it is necessary. It's not a "standard" key from jtreg, so I looked up the
`TEST.ROOT` in JDK project where that key is declared as one of the allowed
ones:
keys=headful sound printer multimon \
i18n intermittent randomness cgroups
Looking at the history of that line, it looks like it was introduced in
https://bugs.openjdk.org/browse/JDK-8078334 and this mailing list thread has
more details https://mail.openjdk.org/pipermail/jdk9-dev/2015-March/001991.html.
I don't know if we have been consistent in using it for tests in the JDK which
use randomness.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/30949#issuecomment-4349711199
