On Tue, 21 Apr 2026 14:45:42 GMT, Matthias Baesken <[email protected]> wrote:
>> okay so should I remove the NOT_PRODUCT ? > >> We need for this to work with PRODUCT builds also. It's unclear to me why >> _valid was initially introduced, and why only for NOT_PRODUCT builds. > > Seems it is used in some debug code, at least removing it breaks the > fastdebug build. i don't think that _valid should be product, it is used in assertion to verify that current metadata is still valid pointer. It is read in assertions only when someone tries to access metadata. It is not a product to save some space. I just wonder why is it zero and not some magic number? I assume that value is zapped somehow druing freeing, but still 0 is not the best number to mark valid objects. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30771#discussion_r3171173382
