On Fri, 1 May 2026 03:23:59 GMT, Leonid Mesnik <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> src/hotspot/share/runtime/javaThread.inline.hpp line 195:
>
>> 193: }
>> 194:
>> 195: void JavaThread::enter_jni_deferred_suspension() {
>
> Why
> `enter_jni_deferred_suspension()` is in this file and
> `jni_deferred_suspension()` with `enter_jni_deferred_suspension()` are in
> other file?
> Also, why enter_jni_deferred_suspension has assertion and this method precond?
I followed the same pattern as for `JavaThread::enter_critical` etc for the
placement.
> Also, why enter_jni_deferred_suspension has assertion and this method precond?
Did you mean `exit_jni_deferred_suspension`? Yes its first assertion could be a
precond too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30936#discussion_r3172436635
