On Thu, 7 May 2026 10:25:11 GMT, Alan Bateman <[email protected]> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   TableStatistics not static, remove Windows special case
>
> src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java line 
> 220:
> 
>> 218:      *
>> 219:      * @param   env
>> 220:      *          A Map of provider-specific settings to configure the 
>> attach, may be null or empty.
> 
> What is the reason for allowing null here?

OK removing this, it has to be a valid Map.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3202126348

Reply via email to