On Fri, 8 May 2026 20:23:03 GMT, Ashutosh Mehra <[email protected]> wrote:
>> VM has a hardcoded requirement on the hardware to have support for SSE2. >> Without SSE2, VM won't even startup. Therefore there is no need to >> explicitly check for SSE2 and/or SSE support, after the initial hardcoded >> check for SSE2. >> This patch clean up the such redundant checks for `supports_sse2()` and >> `supports_sse()`. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ashutosh Mehra has updated the pull request incrementally with one additional > commit since the last revision: > > Address review comments > > Signed-off-by: Ashutosh Mehra <[email protected]> Looks good. Last question: do we want to keep removed features as part of VM_Version::_features_string? I don't have a strong opinion. As a precedent, `VM_Version::cpu_type_description()` explicitly enumerates SSE & SSE2, but it looks outdated. ------------- Marked as reviewed by vlivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31045#pullrequestreview-4255494710 PR Comment: https://git.openjdk.org/jdk/pull/31045#issuecomment-4409974648
