On Wed, 13 May 2026 15:17:47 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Xiaolong Peng has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 386 commits:
>> 
>>  - Merge branch 'openjdk:master' into cas-alloc-1
>>  - Document _collector_allocator_reserved ordering contract
>>  - Tame TestCASAllocContention: fewer threads, shorter run, smaller retention
>>  - Comment: pair reserve-time inflation with read-time compensation
>>    
>>    Cross-reference ShenandoahFreeSet::reserve_alloc_regions_internal at
>>    every 'bytes_allocated - mutator_allocator_remaining' subtraction site.
>>    No behavior change.
>>  - Include mutator allocator remaining bytes in unsafe_max_tlab_alloc
>>  - Reserve mutator alloc regions after abbreviated degenerated GC
>>  - fix: new jtreg tests miss -XX:+UnlockDiagnosticVMOptions
>>  - fix: sync _top before CAS in unset_active_alloc_region
>>  - fix: sync _top once on CAS success and reset_age after the loop in 
>> unset_active_alloc_region
>>  - Add jtreg tests for CAS allocator flag combinations and contention
>>  - ... and 376 more: https://git.openjdk.org/jdk/compare/ebb3d688...ce68d1fa
>
> src/hotspot/share/gc/shared/plab.cpp line 40:
> 
>> 38: }
>> 39: 
>> 40: size_t PLAB::min_byte_size() {
> 
> There is a single use. Inline the implementation to avoid extra shared code 
> changes.

Yes, It is single use for now, I will remove it to avoid change in shared code.

> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp 
> line 421:
> 
>> 419:   size_t allocated_bytes_since_last_sample = 0;
>> 420: 
>> 421:   {
> 
> I think this clashes with https://github.com/openjdk/jdk/pull/31047, which 
> simplifies this path.

Yes, I saw William's PR.  If #31049 is merged before this PR, I'll rework on 
this part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26171#discussion_r3236648456
PR Review Comment: https://git.openjdk.org/jdk/pull/26171#discussion_r3236634906

Reply via email to