On Mon, 8 Jun 2026 16:28:54 GMT, Jatin Bhateja <[email protected]> wrote:
>>> Is `Float16Vector::toString` supposed to return short values in the list? >>> Or should they be formatted as floats? >> >> jshell> import jdk.incubator.vector.* >> jshell> Float16Vector.broadcast(Float16Vector.SPECIES_512, >> Float.floatToFloat16(1.2f)) >> $4 ==> [15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, >> 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, >> 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, 15565, >> 15565] >> >> >> We print the short values from backing storage which encodes IEEE 754 >> binary16 values. > >> @jatin-bhateja In that regard: the Vector API still has lots of unrelated >> bugs, but that should not block you here. But: those JDK27 bugs have higher >> priority for us. >> >> The 3 related issues: are all bugs in the fuzzer changes, of the companion >> PR. We'll have to fix those issues there. >> >> But so far, I think testing has not revealed any issues with this PR here. > > Hi @eme64 , > Thanks for a very thorough testing and filing the bugs. > As discussed I will work on the feedback on fuzzer pull request seperately. > > May I request you to kindly approve this pull request, we may also need > reapproval from @PaulSandoz or @xuemingshen-oracle > > Best Regards > Jatin > @jatin-bhateja I now ran one more round of sanity testing, after your most > recent update. > > Once these tests pass, I can give my approval, with the following expectation: > > * Follow-up issue for `toString` and `hashCode` are filed, and assigned, and > soon addressed. > * The template fuzzer patch is completed before any further `Float16Vector` > enhancements are integrated. > > @jatin-bhateja do you think this is reasonable? Yes sound good to me, can you kindly file the follow up RFEs and assign it to me. I think toString should still print values in verbatim, while NaN canonicalization should mainly be handled for hashCode and equals. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28002#issuecomment-4656585223
