On Tue, 9 Jun 2026 08:28:11 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Help/man update
>
> src/hotspot/share/services/diagnosticCommand.hpp line 748:
>
>> 746: class ClassesDCmd : public DCmdWithParser {
>> 747: private:
>> 748: static constexpr const char *desc = "Print all loaded
>> classes.\nClasses are annotated with flags:\n F = has, or inherits, a
>> non-empty finalize method,\n f = has final method,\n W = methods
>> rewritten,\n C = marked with @Contended annotation,\n R = has been
>> redefined,\n S = is an (App)CDS shared class,\n (if -location is
>> specified, append: 's' (static) or 'd' (dynamic) for AOT cache location)";
>
> It might be better if we write like here document:
> Suggestion:
>
> static constexpr const char *desc =
> "Print all loaded classes.\n
> "Classes are annotated with flags:\n"
> " F = has, or inherits, a non-empty finalize method,\n"
> " f = has final method,\n W = methods rewritten,\n"
> " C = marked with @Contended annotation,\n"
> " R = has been redefined,\n"
> " S = is an (App)CDS shared class,\n"
> " (if -location is specified, append: 's' (static) or 'd' (dynamic)
> for AOT cache location)";
Thanks yes I've got the man page and help text matching now. That line for the
additional shared class flags is shorted than it was and does not need to be on
a new line. In the man page it now puts the flags in a list, no just a block
of text.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31420#discussion_r3379545675
