On Tue, 9 Jun 2026 06:06:27 GMT, David Holmes <[email protected]> wrote:

>> Please review this change to allow XX configuration for specifying a 
>> different /tmp directory for the JVM to use.  In some container 
>> environments, /tmp and /proc/pid/root/tmp might not be usable and an 
>> alternate would be used.  This requires a release note and CSR.   Usage is:
>> 
>> java -XX:AltTempDir=/diags <app>
>> jps -J-XX:AltTempDir=/diags
>> jcmd -J-XX:AltTempDir=/diags <pid> <cmds>
>> 
>> Tested with a couple of tests and locally, and ran tier1-4.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/hotspot/os/linux/os_linux.cpp line 1565:
> 
>> 1563:       AltTempDir = nullptr;
>> 1564:     } else if (!is_writeable_directory(AltTempDir)) {
>> 1565:       log_warning(os)("Error: AltTempDir is ignored because it is not 
>> present or writable");
> 
> Suggestion:
> 
>       log_warning(os)("Error: AltTempDir is ignored because it is not an 
> existing writeable directory");

I thought of changing the function to is_writable_directory() as we have far 
more "writable" than "writeable" overall. 8-)

src/hotspot/share/runtime/arguments.cpp is maybe the best sample of both 
variants.

One online source says, "...writeable is an accepted alternate (often used in 
computing), dropping the "e" is the correct grammatical rule...".  But we are 
not consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3380324431

Reply via email to