On Wed, 10 Jun 2026 16:55:46 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix setting of CopyAVX3Threshold >> >> Signed-off-by: Ashutosh Mehra <[email protected]> > > src/hotspot/cpu/x86/vm_version_x86.cpp line 1726: > >> 1724: >> 1725: if (is_intel()) { // Intel cpus specific settings >> 1726: if (is_knights_family()) { > > I think we can combine checks into one condition here. > > There is separate issue not related to these changes which I realized by > looking on this code. > `-XX:+UseKNLSetting` testing flag checks are guarded by `is_intel()`. > Our testing infra check `avx512` to run tests with this flag. Which worked > before AMD implemented AVX512. Now we run tests on AMD with avx512 but CPU > features are not disabled :( Okay, I will combine them into one condition. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31301#discussion_r3433272996
