On Tue, 2 Jun 2026 06:21:55 GMT, David Holmes <[email protected]> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix another mistake
>>   
>>   Signed-off-by: Ashutosh Mehra <[email protected]>
>
> src/hotspot/cpu/x86/globals_x86.hpp line 182:
> 
>> 180:   /* condition. When this value is set to zero clear operations that */ 
>>     \
>> 181:   /* work on memory blocks can also use AVX512 intrinsics. */           
>>     \
>> 182:   product(int, CopyAVX3Threshold, AVX3Threshold, DIAGNOSTIC,            
>>     \
> 
> I don't think this will work as expected/intended. IIUC this will initialize 
> `CopyAVX3Threshold` to the default build-time value of `AVX3Threshold`, not 
> any runtime value that might be set on the command-line.

Right. I don't need to do that. I can set it `set_vendor_agnostic_vm_config`. 
Thanks for catching the bug.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31301#discussion_r3345494607

Reply via email to