On Tue, 16 Jun 2026 04:48:13 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/lang/System.java line 502: > >> 500: * private fields that might otherwise be hidden by an >> identity object. >> 501: * Developers should be cautious about storing sensitive >> secrets in value object fields. >> 502: * </div> > > It's not clear what kind of information gets exposed and what kind of caution > a developer should exercise when storing sensitive information in fields of > value classes. I think from an application developer point of view, this text > in its current form raises unanswered questions than being a helpful guidance > on what the application developer should do. I agree with Jai. Furthermore, I think it needs explain what things are exposed and in what way they can be discovered. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3466274908
