On Wed, 24 Jun 2026 19:52:23 GMT, Serguei Spitsyn <[email protected]> wrote:

>> The test does not handle exceptions, e.g. `InterruptedException`, in the 
>> `Producer` and `Consumer` threads. This can cause deadlocks. This timeout 
>> issue is hard to reproduce. This update is to add catch any `Throwable` and 
>> log all information needed to understand the root cause.
>> Also, removed unneeded fragment with the call: 
>> `System.loadLibrary(agentLib);`.
>> 
>> Testing:
>>  - Executed the test locally: 
>> `serviceability/jvmti/vthread/VThreadTest/VThreadTest.java`
>>  - TBD: Submit: mach5 tiers 1-3 to be completely safe
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Serguei Spitsyn has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   review: fixed typos in the RuntimeException messages

Marked as reviewed by lmesnik (Reviewer).

Marked as reviewed by lmesnik (Reviewer).

test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java 
line 41:

> 39:     static native boolean check();
> 40: 
> 41:     static void log(String msg) { System.out.println(msg); }

use System.err or flush msg

-------------

PR Review: https://git.openjdk.org/jdk/pull/31581#pullrequestreview-4583275853
PR Review: https://git.openjdk.org/jdk/pull/31581#pullrequestreview-4583277351
PR Review Comment: https://git.openjdk.org/jdk/pull/31581#discussion_r3484604740

Reply via email to