On Fri, 3 Jul 2026 03:56:17 GMT, Patricio Chilano Mateo
<[email protected]> wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2409:
>>
>>> 2407:
>>> 2408: static bool is_downcall_stub(CodeBlob* cb) {
>>> 2409: return cb != nullptr && cb->is_runtime_stub() &&
>>> (strcmp(cb->name(), "nep_invoker_blob") == 0);
>>
>> It is unfortunate to hardcode the name of a stub that is defined/used a long
>> way from here.
>
> Yes, we can add a `DowncallLinker::downcall_stub_name()` method to encode it.
> I didn’t want to generate additional churn touching platform dependent files.
I agree, this is kind of fragile. But I have no intention to insist on anything.
Adding a short comment would help though.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3594226593
