On Thu, 16 Jul 2026 23:38:12 GMT, Patricio Chilano Mateo 
<[email protected]> wrote:

>> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest2/StopThreadTest2.java
>>  line 32:
>> 
>>> 30:  * @requires test.thread.factory == null
>>> 31:  * @library /test/lib /test/hotspot/jtreg
>>> 32:  * @run junit/othervm/native -agentlib:StopThreadTest2 StopThreadTest2
>> 
>> Why the switch to junit? This makes tests very difficult to run outside of 
>> jtreg.
>
> We’ve been using it for tests in `jdk/java/lang/Thread/virtual` when there 
> are multiple independent test cases, since it provides a clean way to 
> structure the testing. Since this one only has two cases, we don’t really 
> need it, so I changed it back to use `main/other`.

Thanks! I'm not a fan of junit in the hotspot tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3599910806

Reply via email to