On Tue, 21 Apr 2026 23:15:02 GMT, Coleen Phillimore <[email protected]> wrote:
> Move JavaClasses for filling in the stack trace in a new file to keep them > together. These classes are very sensitive to inlining which can affect > performance of benchmarks that throw a lot of exceptions (like Dacapo pmd). > > Also remove the work to save the Method name in the backtrace that was used > for the case where redefinition could delete the method in the stack trace. > RedefineClasses ability to add/delete methods has been deprecated for many > releases, so adding code and memory for this case is wasting space and time. > This change speeds up Throwable microbenchmarks by about 10-30%, and speeds > up DaCapo pmd by a bit. > > Tested with tier1-4. > > Integration would be after the valhalla integration, since this will need to > merge with that. It's mostly changing objArrayOops to refArrayOops in the > new javaStackTraceClasses.cpp file. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Hi Coleen, This seems okay in principle but it seems to be a mix of at least three different things. The code relocation would be fine, but it is impossible to see where you have made the changes you mention in that code. It would be better to factor the relocation out into a separate commit (or even PR) so we know it is only a relocation and nothing else. The typeArrayOop cleanup seems completely unrelated and is best moved to its own PR IMO. I don't know what the test changes relate to. Thanks ------------- Changes requested by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30863#pullrequestreview-4750239605
