On Mon, 3 Aug 2026 19:45:07 GMT, Coleen Phillimore <[email protected]> wrote:

>> This fixes the crash when printing deadlocks when the only lock held for the 
>> thread in the deadlock is the JVMTI raw monitor lock.  This also fixes 
>> deadlock detection for only raw monitor locks and adds a test for it.
>> 
>> make test TEST="serviceability/dcmd/thread 
>> vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock 
>> serviceability/jvmti/SuspendWithRawMonitorEnter 
>> serviceability/jvmti/vthread/RawMonitorTest"
>> 
>> Tested with jvmti deadlock detection tests above, and tier 1-4 in progress.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Make loop infinite instead of counted so we get a core file if it fails.

Thank you for updates. Looks good. Posted one nit.
I agree with the endless loop approach.

test/hotspot/jtreg/serviceability/dcmd/thread/libPrintRawMonitorLockTest.cpp 
line 24:

> 22:  */
> 23: 
> 24: #include <string.h>

Nit: Is this include really needed?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32092#pullrequestreview-4851573105
PR Review Comment: https://git.openjdk.org/jdk/pull/32092#discussion_r3710218367

Reply via email to