On Wed, 5 Aug 2026 18:20:59 GMT, Serguei Spitsyn <[email protected]> wrote:

>> This is a minor tweak in the JVMTI intro section with general clarification 
>> for value objects suggested by @AlanBateman.
>> It was decided later that this is for Valhalla post-integration. So, this 
>> will need to be re-based. Also, a CSR will be filed.
>> 
>> Testing: N/A
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Serguei Spitsyn has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   review: fixed typo in section ID

src/hotspot/share/prims/jvmti.xml line 938:

> 936:     that a <jvmti/> agent can associate with an object.
> 937:     Value objects can be tagged by <jvmti/> but the tag is associated 
> with the object's
> 938:     field values, as it has no identity.

Suggestion:

    Value objects can be tagged by <jvmti/> but the tag is associated with the
    values of the object's fields, as it has no identity.

I think it reads a little bit better this way, but I'm fine with what you have 
also. But either wording still is going to require the reader to "connect to 
dots" to come to an understanding of what this really means to them. I guess we 
can wait and see if there is feedback from developers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32211#discussion_r3723020740

Reply via email to