On Fri, 7 Aug 2026 20:04:17 GMT, Stefan Karlsson <[email protected]> wrote:

>> src/hotspot/share/oops/markWord.hpp line 257:
>> 
>>> 255:   }
>>> 256:   ObjectMonitor* monitor() const {
>>> 257:     guarantee(false, "Locking with OM table does not use markWord for 
>>> monitors");
>> 
>> Sounds like `ShouldNotReachHere()` or `ShouldNotCallThis()` :)
>> 
>> Also, if we are prohibiting these calls, how bad it is to remove the method 
>> itself? We expect no real callers for them?
>
> +1

Changed to `ShouldNotCallThis()`, but will defer removing to 
[JDK-8389938](https://bugs.openjdk.org/browse/JDK-8389938).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32257#discussion_r3756418618

Reply via email to