On Tue, 11 Aug 2026 11:26:57 GMT, Coleen Phillimore <[email protected]> wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Updated after review
>> - Merge branch 'master' into 8389325_remove_use_object_monitor_table_flag
>> - 8389325: Remove the UseObjectMonitorTable flag and related code
>
> src/hotspot/share/runtime/synchronizer.cpp line 2174:
>
>> 2172: if (!UseObjectMonitorTable) {
>> 2173: // Do the old inflate and enter.
>> 2174: monitor = inflate_into_object_header(object, cause,
>> locking_thread, current);
>
> I think you can remove the method inflate_into_object_header since it was
> added for the non-OMT case.
It's in the runtime code so I think it should be removed with this change.
> src/hotspot/share/runtime/synchronizer.cpp line 2207:
>
>> 2205: }
>> 2206:
>> 2207: ObjectMonitor* ObjectSynchronizer::read_monitor(markWord mark) {
>
> Shouldn't this version of read_monitor be deleted too?
For some reason I thought this was important enough for performance to be
inlined. Maybe not.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32257#discussion_r3757560465
PR Review Comment: https://git.openjdk.org/jdk/pull/32257#discussion_r3757531764
