On Thu, 13 Aug 2026 22:41:20 GMT, David Holmes <[email protected]> wrote:

>> Timofei has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Add regression test for FollowReferences
>>  - Delete unreachable code
>
> So you are saying that `java_lang_Class::as_Klass(k_mirror)` can never 
> evaluate to nullptr because `k_mirror` is not null and it does not represent 
> a primitive type, therefore it must be a non-null klass type. That sounds 
> reasonable, but I think we should assert that. The PR description then needs 
> to be updated to reflect the actual change.
> 
> I don't see the relevance of the regression test though.

@dholmes-ora, Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32253#issuecomment-5291228649

Reply via email to