On Tue, 25 Aug 2026 02:34:39 GMT, Serguei Spitsyn <[email protected]> wrote:
> Thank you for update. The `TestDescription.java` launchers still pass the
> `-verbose` flag. What is the plan on this? Is it going to be a separate
> cleanup or it is missed?
>
> Also, I see the following code in
> `test/hotspot/jtreg/vmTestbase/nsk/jdi/Accessible/isPrivate/isPrivate001.java`:
>
> ```
> if (argsHandler.verbose()) {
> debugee = binder.bindToDebugee(debugeeName + " -vbs");
> } else {
> debugee = binder.bindToDebugee(debugeeName);
> }
> ```
>
> The file:
> `test/hotspot/jtreg/vmTestbase/nsk/jdi/Accessible/isProtected/isProtected001.java`
> has the same pattern. Could you double check for the same pattern in other
> files? I guess, the parameter " -vbs" should not be passed in the updated
> tests.
>
> The following files have same issue:
>
> * test/hotspot/jtreg/vmTestbase/nsk/jdi/Accessible/isPublic/isPublic001.java
> * test/hotspot/jtreg/vmTestbase/nsk/jdi/Accessible/modifiers/modifiers001.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassObjectReference/reflectedType/reflectype001.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allFields/allfields002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/allMethods/allmethods002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/fieldByName/fieldbyname002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_s/methbyname_s002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/methodsByName_ss/methbyname_ss002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleFields/visibfield002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/visibleMethods/visibmethod002.java
> *
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/classesByName/classesbyname001.java
>
> I see some comments referring `test argument -vbs`. Also, the following
> variable is defined and used: `verbose_mode`. Is it going to be fixed
> separately?
Fixed both in this PR. Dropped verbose from the launchers of all the converted
tests and removed the vbs binder conditional, your list plus a few more the
sweep found. The debugger side verbose_mode and its print helpers im leaving
for the follow up that covers the rest of the suite, that’s a bigger pass, the
helpers there have three different behaviors including one that only prints
when not verbose.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/32375#issuecomment-5412289373
