On Thu, 27 Aug 2026 14:21:26 GMT, Stefan Karlsson <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed the assert, we have other checks for inconsistent locking > > src/hotspot/share/oops/markWord.hpp line 52: > >> 50: // klass:22 hash:31 valhalla:4 age:4 self-fwd:1 lock:2 >> 51: // >> 52: // - lock bits are used to describe lock states: >> fast-locked/lock-neutral/inflated > > It would be nice to get a little bit more info about the lock-neutral > concept. I wonder if the following conveys the information, and at the same > time is terse enough that it gets read? > > > // - lock bits are used to describe lock states and GC marking / fowarding > // > // [header | 00] fast_locked object has been fast-locked > // [header | 01] lock_neutral object has no monitor and is not > locked > // [header | 10] monitor object has a monitor (lock state > recorded there) > // [ptr | 11] marked used to mark an object (header is > swapped out) I was just trying to improve these comments. But I like your version more than what I was working with. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32544#discussion_r3872664602
