On Tue, 8 Sep 2026 18:18:59 GMT, Frederic Parain <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - @fparain review comments
>> - Changed inline_xxx to flat_xxx
>
> src/hotspot/share/cds/aotMapLogger.cpp line 879:
>
>> 877: for (int i = 0; i < _indent + 1; i++) _st->print(" ");
>> 878: _st->print_cr(" - [null_marker] @%d %s",
>> 879: field_offset_in_obj +
>> vk->null_marker_offset(),
>
> `vk->null_marker_offset()` returns of the offset of the null-marker as an
> offset from the beginning of the object for a heap buffered value.
> Shouldn't `null_marker_offset_in_payload()` be used instead?
I fixed the problem, which also existed in `fieldDescriptor::print_on()`. I
added a few test cases for the location of the null markers. I tried to avoid
assumptions about how the fields are laid out. The only assumptions in the test:
- `java.lang.Integer` payload is 4 bytes
- the null marker is located immediately after the payload
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32565#discussion_r3963130590
