On Wed, 9 Sep 2026 05:55:55 GMT, Axel Boldt-Christmas <[email protected]>
wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated after review
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Mark.java line 136:
>
>> 134: public boolean isBeingInflated() {
>> 135: return (value() == 0);
>> 136: }
>
> I wonder if we should just remove this as well. It is old legacy locking
> displaced markWord related.
>
> Suggestion:
Removed `isBeingInflated()`.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Mark.java line 151:
>
>> 149: }
>> 150: public boolean hasMonitor() {
>> 151: // Align SA’s decoding with markWord::has_monitor().
>
> Seems like an unnecessary comment to have in the code. I would have expected
> a comment if for some reason we did not align the SA's mirror implementation
> with the HotSpot code. _(Also that is an exotic apostrophe `’` vs `'`)_
>
>
> Suggestion:
I agree, so I've removed the comment.
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java
> line 30:
>
>> 28:
>> 29: import sun.jvm.hotspot.oops.*;
>> 30: import sun.jvm.hotspot.utilities.*;
>
> Maybe this are imported "just cause".
>
> But the last use of the import was removed with the `Asserts` removal.
>
>
> Suggestion:
Removed: `import sun.jvm.hotspot.utilities.*;`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32758#discussion_r3966641814
PR Review Comment: https://git.openjdk.org/jdk/pull/32758#discussion_r3966634847
PR Review Comment: https://git.openjdk.org/jdk/pull/32758#discussion_r3966648719
