On Sat, 12 Sep 2026 05:51:12 GMT, Yasumasa Suenaga <[email protected]> wrote:

> After Valhalla, `InstanceKlass::size()` in HotSpot adds sizeof 
> `ValueKlass::Members` for value class, however SA does not do. It caused the 
> failure in TestInstanceKlassSize.java with `--enable-preview`.
> 
> This PR fixes the problem, and adds the test for `java.lang.Byte` to 
> TestInstanceKlassSize.java again (removed by JEP 401).
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

The fix itself looks okay to me. But I'm not sure the test update provides a 
necessary test coverage as the `--enable-preview` option has to be passed for 
it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32848#issuecomment-5693839452

Reply via email to