On Wed, 16 Sep 2026 12:43:27 GMT, Matthias Baesken <[email protected]> wrote:

> We should remove the default argument from strdup_check_oom mem_tag parameter 
> and adjust the parameters from mtInternal to other categories where 
> appropriate.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good to me.

src/hotspot/share/runtime/flags/jvmFlagAccess.cpp line 327:

> 325:   char* new_value = nullptr;
> 326:   if (*value != nullptr) {
> 327:     new_value = os::strdup_check_oom(*value, mtInternal);

Some flag code uses mtArguments. Maybe that would be correct here as well?

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32905#pullrequestreview-5222932036
PR Review Comment: https://git.openjdk.org/jdk/pull/32905#discussion_r4026260410

Reply via email to