On Thu, 17 Sep 2026 05:52:10 GMT, Yasumasa Suenaga <[email protected]> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Service agent fixes
>
> src/hotspot/share/runtime/vmStructs.cpp line 227:
> 
>> 225:   nonstatic_field(InstanceKlass,               
>> _adr_value_klass_members,                      address)                      
>>          \
>> 226:   nonstatic_field(ValueKlass::Members,         
>> _available_layouts._payload_offset,            int)                          
>>          \
>> 227:   nonstatic_field(ValueKlass::Members,         
>> _available_layouts._null_marker_offset,        int)                          
>>          \
> 
> SA should follow HotSpot structure as possible.
> It is better to add mirror class of `LayoutDescriptions` into SA, and it 
> should be used. I think you can refer `ValueKlass::Members` to know how SA 
> accesses internal fields.

I would like that to be a future RFE. This RFE has already endured enough scope 
creep.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32276#discussion_r4033943852

Reply via email to