On Mon, 21 Sep 2026 15:07:24 GMT, Chris Plummer <[email protected]> wrote:
>> Could there be something overwritten in the signature in error cases, that >> leads to 'bad'/broken method signatures? > > That sill sounds like a bug that should be caught with an assert. I don't see > how GCC can make any assumptions about a string returned by GetMethodName(). > It has to have a SIGNATURE_END_ARGS in it. GCC can't know that, but that > shouldn't lead to it to thinking strchr can return NULL in this case. In util.c https://github.com/openjdk/jdk/blob/46fbea9c4b9b628e43dd8474bde2bd8e984bf857/src/jdk.jdwp.agent/share/native/libjdwp/util.c#L756 we null-check after strchr, so being more consistent here and do the null-check too in production code would make sense. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32929#discussion_r4156675086
