On Thu, 22 Oct 2026 02:36:00 GMT, Yasumasa Suenaga <[email protected]> wrote:

> So can I exclude change for GXL from this PR?

You can exclude supporting flat objects in HeapGXLWriter, but the issue is that 
your current changes break HeapGXLWriter, even when not using --enable-preview. 
You need to fix the override issue to keep HeapGXLWriterL working. For example, 
when AbstractHeapGraphWriter calls writeObjectArray((ObjArray)oop, 
flatObjects), there needs to be a HeapGXLWriter.writeObjectArray() with the 
same signature. You can use the existing HeapGXLWriter.writeObjectArray() that 
takes a single argument and change it take both arguments and ignore 
flatObjects.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33395#issuecomment-6331506231

Reply via email to