On Thu, 22 Oct 2026 06:41:08 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Valhalla introduced flattened value object, however SA cannot dump it into
>> heapdump e.g. `jhsdb jmap --binaryheap`.
>> Actually HeapHprofBinWriter.java has following lines. Hence the user cannot
>> check flattened object from heapdump generated by SA.
>>
>>
>> case JVM_SIGNATURE_CLASS:
>> case JVM_SIGNATURE_ARRAY: {
>> if (field.isFlat()) {
>> // FIXME - we don't handle flattened fields yet. Just treat
>> them
>> // as a null reference. See JDK-8381370.
>> writeObjectID(null);
>>
>>
>> This PR addressed it.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Yasumasa Suenaga has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update testcase
The changes look good now.
I looked a bit more into the GXL support and I'm starting to think we should
just remove it. It hasn't been maintained and I doubt we have customers for it.
I've never heard anyone complain about it not working, even though I'm pretty
sure it is broken. It's also not something supported by "jcmd GC.heap_dump". We
can file a separate CR for its removal.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/33395#pullrequestreview-5617591514
