On Thu, 22 Oct 2026 02:58:11 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Yunbo Zhang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8343851: Slow new array creation in case of many classes loaded
>
> src/jdk.jdwp.agent/share/native/libjdwp/ArrayTypeImpl.c line 98:
>
>> 96:
>> 97: /* Hidden classes and their arrays are not included in
>> GetClassLoaderClasses. */
>> 98: if (strchr(componentSignature, '.') == NULL) {
>
> Nit: I'd suggest to add a comment at line 98 explaining that we are checking
> for non-hidden class case. You need to figure this out yourselves if there is
> no comment.
Thanks. I've updated the comment.
`Hidden classes and their arrays have '.' in their signatures and are not
included in GetClassLoaderClasses.`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33414#discussion_r4347688347
