On Tue, 3 Nov 2026 01:31:03 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge branch 'master' into JDK-8381370
>> - Update testcase
>> - Fix
>> - fix
>> - Re-enable HeapDumpTestWithActiveProcess.java
>> - Merge branch 'master' into JDK-8381370
>> - Use getFieldHolder() rather than getKlass()
>> - 8381370: SA is not writing out flattened fields to the hprof file
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
> line 1249:
>
>> 1247: private long generateIDForFlatObj() {
>> 1248: // to avoid conflicts with oop addresses skip aligned values.
>> 1249: // FlatObjectDumper::get_id() returns -1 (ULONG_MAX) if it
>> reaches max value, not rouded.
>
> Nit: Typo at line 1249: `rouded` => `rounded`
Thank you! Fixed.
> test/hotspot/jtreg/serviceability/sa/LingeredAppWithValueObject.java line 112:
>
>> 110:
>> 111: @NullRestricted
>> 112: private static NonNullValueThreadObj nonNullValThreadObj;
>
> Q: Is this `@NullRestricted` really needed?
> The type `NonNullValueThreadObj` extends `Thread` which is an identity
> class.
> Instead, is there a need for this annotation at line 91: `public final
> Rec rec`?
I moved `@NullRestricted` to decorate `rec`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33395#discussion_r4450460458
PR Review Comment: https://git.openjdk.org/jdk/pull/33395#discussion_r4450464078
