On Tue, 3 Nov 2026 16:11:07 GMT, Emanuel Peter <[email protected]> wrote:
>> @eme64 Thanks for the review! I've updated the test based on your feedback. >> >> - Added 10 vector types: all six element types for 128-bit, and >> Byte/Short/Int/Float for 64-bit. >> - Excluded `LongVector64` and `DoubleVector64`, which have a single lane: >> - `LongVector64`: C2 rejects both load and reduction on aarch64 and x86. >> - `DoubleVector64`: rejected on aarch64. On x86, the load is allowed, but >> the reduction is still rejected. >> >> (x86 was checked under Rosetta) >> >> As for floats, both `FloatVector128` and `FloatVector64` decode as >> `Location::vector`. > > Any chance you could just iterate over ALL vector types (element types and > sizes), including `Float16Vector` as well? > > I know that not all of those actually will generate vectors on all platforms. > But it would still be good to exercise all variants, in case more of them are > supported by hardware in the future. The SA should generate something > sensible for all cases, right? So either a SIMD vector or the object wrapping > the array payload. > > You can of course also have a list of vector types where you expect to get > the SIMD vector, and and assert that - as you are doing now. Hi @eme64, Just a friendly ping on this. I’ve pushed a commit addressing your feedback (7736ba0). Could you take another look when you get a chance? Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33665#discussion_r4532336878
