An,

Im pretty sure all of the patches have already been merged.

Thanks,

Brady


On 12/08/16 18:56, An Ho wrote:

Looks like the patch verify passed successfully. Should we merge the Boron patches for RC0?

Best Regards,

An Ho

*From:*Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco) [mailto:tcech...@cisco.com]
*Sent:* Friday, August 12, 2016 5:42 AM
*To:* Brady Allen Johnson; Anil Vishnoi; Brady Johnson
*Cc:* netvirt-...@lists.opendaylight.org; sfc-dev@lists.opendaylight.org; openflowplugin-...@lists.opendaylight.org; An Ho; groupbasedpolicy-...@lists.opendaylight.org; rele...@lists.opendaylight.org; Sam Hague *Subject:* RE: [groupbasedpolicy-dev] [openflowplugin-dev] [sfc-dev] [release] Merge a large Openflow plugin patch to master and stable/boron today

No worries, just waiting for +1 from Jenkins in stable boron patch.

Tomas



Think before you print.Think before you print.

This email may contain confidential and privileged material for the sole use of the intended recipient. Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender by reply email and delete all copies of this message.

For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html

*From:*Brady Allen Johnson [mailto:brady.allen.john...@ericsson.com]
*Sent:* Friday, August 12, 2016 12:57 PM
*To:* Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco); Anil Vishnoi; Brady Johnson *Cc:* netvirt-...@lists.opendaylight.org <mailto:netvirt-...@lists.opendaylight.org>; sfc-dev@lists.opendaylight.org <mailto:sfc-dev@lists.opendaylight.org>; openflowplugin-...@lists.opendaylight.org <mailto:openflowplugin-...@lists.opendaylight.org>; An Ho; groupbasedpolicy-...@lists.opendaylight.org <mailto:groupbasedpolicy-...@lists.opendaylight.org>; rele...@lists.opendaylight.org <mailto:rele...@lists.opendaylight.org>; Sam Hague *Subject:* Re: [groupbasedpolicy-dev] [openflowplugin-dev] [sfc-dev] [release] Merge a large Openflow plugin patch to master and stable/boron today


The GBP patch in master [0] just verified successfully, and I see that Tomas just merged it.

The GBP patch in stable/boron [1] failed the distribution check. That happened because the netvirt patch in stable/boron [2] failed the merge check. I just did a "remerge" on it.

Hopefully all of this will be finished in a hour or so.

Tomas, you will also need to merge the GBP-SFC demo updates:

master: https://git.opendaylight.org/gerrit/#/c/42869 <https://git.opendaylight.org/gerrit/#/c/42869> stable/boron: https://git.opendaylight.org/gerrit/#/c/43702 <https://git.opendaylight.org/gerrit/#/c/43702>

Thanks,

Brady

[0] https://git.opendaylight.org/gerrit/#/c/40945/
[1] https://git.opendaylight.org/gerrit/#/c/43700/
[2] https://git.opendaylight.org/gerrit/#/c/43699/

On 12/08/16 12:13, Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco) wrote:

    Hi Anil,

    We are aware, working on fixing it asap.

    Tomas

    http://www.cisco.com/web/europe/images/email/signature/logo05.jpg

    *Tomas Cechvala*
    Engineer - Software
    tcech...@cisco.com <mailto:tcech...@cisco.com>
    Phone:

        

    *Cisco Systems Limited*




    SK
    Cisco.com <http://www.cisco.com>

        


    Think before you print.Think before you print.

    This email may contain confidential and privileged material for
    the sole use of the intended recipient. Any review, use,
    distribution or disclosure by others is strictly prohibited. If
    you are not the intended recipient (or authorized to receive for
    the recipient), please contact the sender by reply email and
    delete all copies of this message.

    For corporate legal information go to:
    http://www.cisco.com/web/about/doing_business/legal/cri/index.html

    *From:*groupbasedpolicy-dev-boun...@lists.opendaylight.org
    <mailto:groupbasedpolicy-dev-boun...@lists.opendaylight.org>
    [mailto:groupbasedpolicy-dev-boun...@lists.opendaylight.org] *On
    Behalf Of *Anil Vishnoi
    *Sent:* Friday, August 12, 2016 9:46 AM
    *To:* Brady Johnson
    *Cc:* netvirt-...@lists.opendaylight.org
    <mailto:netvirt-...@lists.opendaylight.org>;
    sfc-dev@lists.opendaylight.org
    <mailto:sfc-dev@lists.opendaylight.org>;
    openflowplugin-...@lists.opendaylight.org
    <mailto:openflowplugin-...@lists.opendaylight.org>; Brady Allen
    Johnson; An Ho; groupbasedpolicy-...@lists.opendaylight.org
    <mailto:groupbasedpolicy-...@lists.opendaylight.org>;
    rele...@lists.opendaylight.org
    <mailto:rele...@lists.opendaylight.org>; Sam Hague
    *Subject:* Re: [groupbasedpolicy-dev] [openflowplugin-dev]
    [sfc-dev] [release] Merge a large Openflow plugin patch to master
    and stable/boron today

    Netvirt distribution is failing because of this error

    Could not start bundle
    mvn:org.opendaylight.groupbasedpolicy/ofoverlay-renderer/0.5.0-SNAPSHOT
    in feature(s) *odl-groupbasedpolicy-ofoverlay-0.5.0-SNAPSHO*T: The
    bundle
    "org.opendaylight.groupbasedpolicy.ofoverlay-renderer_0.5.0.SNAPSHOT
    [529]" could not be resolved. Reason: Missing Constraint:
    Import-Package:
    
org.opendaylight.yang.gen.v1.urn.opendaylight.openflowplugin.extension.nicira.action.rev140714.nx.action.set.nshc._1.grouping;
    version="[0.4.0,1.0.0)"

            at
    
org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:403)

            at
    Proxy18e377b3_b7c4_4d5b_b905_3ccb6d7fc89e.installFeature(Unknown
    Source)

            at
    
org.opendaylight.odlparent.featuretest.SingleFeatureTest.installFeature(SingleFeatureTest.java:308)

            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

            at
    
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

            at
    
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

            at java.lang.reflect.Method.invoke(Method.java:498)

            at
    
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)

            at
    
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)

            at
    
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)

            at
    
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)

            at
    
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)

            at
    
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)

            at java.util.concurrent.FutureTask.run(FutureTask.java:266)

            at java.lang.Thread.run(Thread.java:745)

    So looks like we are kind of in dependency cycle, gbp distribution
    probably will fail because of netvirt and netvirt is failing
    because of gbp, so we need to override the jenkins verify and
    merge one of the patch.

    I am merging netvirt patch (carbon), so hopefully gbp patch will
    get verified.

    On Thu, Aug 11, 2016 at 5:59 PM, Brady Johnson
    <bradyallenjohn...@gmail.com <mailto:bradyallenjohn...@gmail.com>>
    wrote:

    I was away from the PC for a few hours, and am back now. I'll fix
    this patch now and get it merged.

    Thanks for you patience. I'll let you know when its merged.

    Brady

    On Fri, Aug 12, 2016 at 2:04 AM, Sam Hague <sha...@redhat.com
    <mailto:sha...@redhat.com>> wrote:

    The verify job was failing because of a couple test in sfc
    failing. I pushed [1] to comment out the two failing tests. That
    isn't the right fix but it should let the job verify if those were
    the only two problems.

    Once that gets in can we get the other patches in that should go
    with the openflow changes? And other patches that have been
    failing to verify?


    [1] https://git.opendaylight.org/gerrit/43763

    On Thu, Aug 11, 2016 at 6:44 PM, Brady Johnson
    <bradyallenjohn...@gmail.com <mailto:bradyallenjohn...@gmail.com>>
    wrote:

    An,

    The SFC verify job is failing. I'm away from the pc now and am not
    sure what the problem is. Seems like it's not related to sfc nor
    the open flow patch.

    https://git.opendaylight.org/gerrit/#/c/43698/

    Any ideas anyone?

    Brady

    On Aug 12, 2016 00:39, "An Ho" <an...@huawei.com
    <mailto:an...@huawei.com>> wrote:

        Hi,

        Any update on the status of this?  It may be holding up
        netvirt at the moment [1] since sfc needs to go in and then
        netvirt and gbp.

        Best Regards,

        An Ho

        [1]
        https://lists.opendaylight.org/pipermail/release/2016-August/007851.html

        *From:*release-boun...@lists.opendaylight.org
        <mailto:release-boun...@lists.opendaylight.org>
        [mailto:release-boun...@lists.opendaylight.org
        <mailto:release-boun...@lists.opendaylight.org>] *On Behalf Of
        *Brady Allen Johnson
        *Sent:* Thursday, August 11, 2016 3:48 AM
        *To:* rele...@lists.opendaylight.org
        <mailto:rele...@lists.opendaylight.org>;
        sfc-dev@lists.opendaylight.org
        <mailto:sfc-dev@lists.opendaylight.org>;
        openflowplugin-...@lists.opendaylight.org
        <mailto:openflowplugin-...@lists.opendaylight.org>;
        netvirt-...@lists.opendaylight.org
        <mailto:netvirt-...@lists.opendaylight.org>;
        groupbasedpolicy-...@lists.opendaylight.org
        <mailto:groupbasedpolicy-...@lists.opendaylight.org>; Manuel Buil
        *Subject:* [release] Merge a large Openflow plugin patch to
        master and stable/boron today


        Hello all,

        According to this API freeze waiver [0], I have reached
        agreement with the Netvirt, SFC, Group Based Policy (GBP) and
        Openflow plugin (OFP) projects to merge the following patches
        on master (Carbon) and to stable/boron:

        Patches on master (Carbon)

        OFP: https://git.opendaylight.org/gerrit/#/c/37937
        SFC: https://git.opendaylight.org/gerrit/#/c/37944
        Netvirt: https://git.opendaylight.org/gerrit/#/c/40942
        GBP: https://git.opendaylight.org/gerrit/#/c/40945


        Cherry picked patches on stable/boron:

        OFP: https://git.opendaylight.org/gerrit/#/c/43697
        SFC: https://git.opendaylight.org/gerrit/#/c/43698
        Netvirt: https://git.opendaylight.org/gerrit/#/c/43699
        GBP: https://git.opendaylight.org/gerrit/#/c/43700


        GBP will also need these changes for the GBP-SFC demo:

        master: https://git.opendaylight.org/gerrit/#/c/42869
        stable/boron: https://git.opendaylight.org/gerrit/#/c/43702


        I just wanted to give everybody a heads-up that these changes
        will be merged today. The Openflow plugin patch (37937) above
        is failing the distro-check. We know about this, and its
        because SFC is failing in the distro, since its built against
        the previous OFP API.

        Here is how we will go about merging the above 10 patches:

          * First we'll merge the patches in master (Carbon)

              o We'll start with the OFP patch, which we will have to
                manually override the verify to +1
              o Next, we'll merge SFC
              o Then we will merge the Netvirt and GBP patches

          * Next, we'll merge the cherry picked patches in
            stable/boron, in the same order as we did in master


        These patches have been tested downstream in OPNFV SFC and in
        the GBP-SFC demo, so we dont expect any disturbances.

        Regards,

        Brady

        [0]
        
https://lists.opendaylight.org/pipermail/groupbasedpolicy-dev/2016-July/003481.html

        _______________________________________________
        sfc-dev mailing list
        sfc-dev@lists.opendaylight.org
        <mailto:sfc-dev@lists.opendaylight.org>
        https://lists.opendaylight.org/mailman/listinfo/sfc-dev


    _______________________________________________
    openflowplugin-dev mailing list
    openflowplugin-...@lists.opendaylight.org
    <mailto:openflowplugin-...@lists.opendaylight.org>
    https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev



--
    Thanks

    Anil


_______________________________________________
sfc-dev mailing list
sfc-dev@lists.opendaylight.org
https://lists.opendaylight.org/mailman/listinfo/sfc-dev
        • ... Shuva Jyoti Kar
  • Re: [sfc-dev... An Ho
    • Re: [sf... Brady Johnson
      • Re:... Sam Hague
        • ... Brady Johnson
          • ... Anil Vishnoi
            • ... Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco)
              • ... Brady Allen Johnson
              • ... Tomas Cechvala -X (tcechval - PANTHEON TECHNOLOGIES at Cisco)
              • ... An Ho
              • ... Brady Allen Johnson

Reply via email to