Hi Sam, Both the patches had to be merged together. As my review has been merged but genius CSIT patch is not; Genius CSIT jobs are failing.
Thanks & Regards, Dimple. From: Vishal Thapar [mailto:vtha...@redhat.com] Sent: Monday, January 28, 2019 7:12 AM To: Sam Hague <sha...@redhat.com> Cc: Dimple Jain <dimple.j...@ericsson.com>; odl netvirt dev <netvirt-...@lists.opendaylight.org>; 'genius-...@lists.opendaylight.org' (genius-...@lists.opendaylight.org) <genius-...@lists.opendaylight.org>; sfc-dev@lists.opendaylight.org; Brady Johnson <bjohn...@inocybe.ca> Subject: Re: [genius-dev] [netvirt-dev] [sfc-dev] Disable BFD monitoring for tunnels by default On Mon, Jan 28, 2019 at 4:21 AM Sam Hague <sha...@redhat.com<mailto:sha...@redhat.com>> wrote: On Wed, Jan 23, 2019, 5:58 AM Dimple Jain <dimple.j...@ericsson.com<mailto:dimple.j...@ericsson.com> wrote: Hi Sam, I have raised a patch to disable BFD by default and Karthika has modified genius csit accordingly. Here are the patches for the same. Both the patches should be merged together. Can you please review and merge. The genius patch is merged. Does it matter if the CSIT patch is not? It will need to be merged. Genius CSIT's BFD suite has tests for default behavior which will now change. And do we need anything for netvirt? There is a direct tunnel suite there also. Nope. Direct tunnels are a different change, will likely be done during Sodium. And what about the plain netvirt CSIT, is that just going to have bfd disabled? Yes. Code in netvirt never really used BFD state changes. We also plan to move to OFTunnels soon and BFD is not supported with OFTunnels. https://git.opendaylight.org/gerrit/#/c/79629/ https://git.opendaylight.org/gerrit/#/c/79836/ Thanks & Regards, Dimple. From: netvirt-dev-boun...@lists.opendaylight.org<mailto:netvirt-dev-boun...@lists.opendaylight.org> [mailto:netvirt-dev-boun...@lists.opendaylight.org<mailto:netvirt-dev-boun...@lists.opendaylight.org>] On Behalf Of Brady Johnson Sent: Thursday, December 20, 2018 2:34 PM To: Faseela K <faseel...@ericsson.com<mailto:faseel...@ericsson.com>> Cc: odl netvirt dev <netvirt-...@lists.opendaylight.org<mailto:netvirt-...@lists.opendaylight.org>>; genius-...@lists.opendaylight.org<mailto:genius-...@lists.opendaylight.org>; sfc-dev@lists.opendaylight.org<mailto:sfc-dev@lists.opendaylight.org> Subject: Re: [netvirt-dev] [sfc-dev] Disable BFD monitoring for tunnels by default No objections from me, thanks. Regards, Brady Johnson bjohn...@inocybe.ca<mailto:bjohn...@inocybe.ca> On Thu, Dec 20, 2018 at 6:31 AM Faseela K <faseel...@ericsson.com<mailto:faseel...@ericsson.com>> wrote: Brady/David, Any objections from sfc side? Thanks, Faseela From: Sam Hague [mailto:sha...@redhat.com<mailto:sha...@redhat.com>] Sent: Wednesday, December 19, 2018 10:30 PM To: Faseela K <faseel...@ericsson.com<mailto:faseel...@ericsson.com>> Cc: genius-...@lists.opendaylight.org<mailto:genius-...@lists.opendaylight.org>; sfc-dev@lists.opendaylight.org<mailto:sfc-dev@lists.opendaylight.org>; odl netvirt dev <netvirt-...@lists.opendaylight.org<mailto:netvirt-...@lists.opendaylight.org>>; Brady Allen Johnson <bjohn...@inocybe.ca<mailto:bjohn...@inocybe.ca>> Subject: Re: [sfc-dev] Disable BFD monitoring for tunnels by default On Sat, Dec 15, 2018 at 9:42 AM Faseela K <faseel...@ericsson.com<mailto:faseel...@ericsson.com>> wrote: Hi, There was a discussion in last genius weekly call, whether we can disable tunnel monitoring by default. Vishal indicated that netvirt would prefer disabling monitoring by default. And can be enabled explicitly if required. Any concerns if we do that? This is a good idea. We talked about this a while back also and thought we decided to do the same. The upstream netvirt csit does not use bfd. Does disabling the bfd have any impact on the tunnel issues that are being debugged or is this a benign change? This would clean up the logs also as the bfd stuff is noisy in the ovsdb/vswitchd logs that the upstream csit collects. Thanks, Faseela _______________________________________________ sfc-dev mailing list sfc-dev@lists.opendaylight.org<mailto:sfc-dev@lists.opendaylight.org> https://lists.opendaylight.org/mailman/listinfo/sfc-dev _______________________________________________ genius-dev mailing list genius-...@lists.opendaylight.org<mailto:genius-...@lists.opendaylight.org> https://lists.opendaylight.org/mailman/listinfo/genius-dev
_______________________________________________ sfc-dev mailing list sfc-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/sfc-dev
