On Wed, Dec 31, 2008 at 9:06 PM, Danek Duvall <danek.duvall at sun.com> wrote: > On Wed, Dec 31, 2008 at 12:58:37AM -0500, Brian Gupta wrote: > >> Can I please get a review? >> >> http://cr.opensolaris.org/~brandorr/vim72-webrev > > I'll note that patch 77 has come out, which appears to fix a bug in paatch > 76, so you should bring that in. What are "MD5" and "MD5SUMS" doing there? > What about "README"? Did you just do a bulk download of the 7.2 patch > directory?
Updated to include 77, and got rid of the rest. :) > You should get rid of all the 7.1 patches. Where do you see the 7.1 patches? I cant find any. > Are there really no new files in 7.2 that the packaging hasn't changed? > Indeed, taking a look at the runtime directories from the two source > tarballs, there are some new files and some files that have been removed. There are changes, mostly minor: For example http://cr.opensolaris.org/~brandorr/vim72-webrev/usr/src/cmd/vim/Makefile.sfw.patch > I also see that install-sfw hasn't been changed, and given that this has a > dependency on the version of vim, it'll need to change as well. How did > that change miss your webrev -- you couldn't have built the gate without > it. Added install.sfw to the file list. I will generate and upload the new webrev shortly. > You should also generate a webrev that doesn't include any of the files > you're not modifying. I don't know if that's possible from the outside, > though. > >> http://cr.opensolaris.org/~brandorr/gvim72-webrev > > Everything here shows up as new. Can you generate the webrev against a > gate that already has gvim in it? Gvim goes into SFW at build 105, thus there is nothing to compare this against. Should we hold off? > Danek > -Brian -- - Brian Gupta http://opensolaris.org/os/project/nycosug/ http://www.genunix.org/wiki/index.php/OpenSolaris_New_User_FAQ New York City user groups calendar: http://nyc.brandorr.com/
