On Wed, Dec 31, 2008 at 12:58:37AM -0500, Brian Gupta wrote: > Can I please get a review? > > http://cr.opensolaris.org/~brandorr/vim72-webrev
I'll note that patch 77 has come out, which appears to fix a bug in paatch 76, so you should bring that in. What are "MD5" and "MD5SUMS" doing there? What about "README"? Did you just do a bulk download of the 7.2 patch directory? You should get rid of all the 7.1 patches. Are there really no new files in 7.2 that the packaging hasn't changed? Indeed, taking a look at the runtime directories from the two source tarballs, there are some new files and some files that have been removed. I also see that install-sfw hasn't been changed, and given that this has a dependency on the version of vim, it'll need to change as well. How did that change miss your webrev -- you couldn't have built the gate without it. You should also generate a webrev that doesn't include any of the files you're not modifying. I don't know if that's possible from the outside, though. > http://cr.opensolaris.org/~brandorr/gvim72-webrev Everything here shows up as new. Can you generate the webrev against a gate that already has gvim in it? > P.S. - Confirming that I will need to submit an ARC case to bump > versions from 7.1 to 7.2? Like Jim said, you likely won't have to, if there aren't any Public interfaces that changed. I'll go out on a limb and say there aren't, but if there turn out to be some, we can go back and file a case for it. Danek
