Martina, A few more comments (quick skip through)...
Paul Martina Tomisova wrote: > > sorry for the late answer - I had been ill... > > The webrev is updated at http://cr.opensolaris.org/~martina/gdbm/. > > All your suggestions were processed except this one: > >> 8. source tarball >> This is not in your webrev - add so RTIer knows it will >> be checked-in with the other stuff. > > The tarball file is listed at the 'putback -n' list at the beginning of the > webrev. I do not include this file to the rest of the webrev because it > caused some warning notifications... RTIers are used to this I think... 1. usr/src/lib/gdbm/Makefile.sfw Combine the lines ... 96 -rm -rf $(VER) 97 -rm -rf $(VER64) to ... -rm -rf $(VER) $(VER64) 2. usr/src/lib/gdbm/install-sfw & usr/src/lib/gdbm/install-sfw-64 use /usr/bin/ksh93 instead of /bin/sh and add a '$ set -o errexit' near the top 3. usr/src/lib/gdbm/install-sfw remove the 'write permission' bit on gdbm.h (line 54) 4. usr/src/pkgdefs/SUNWgnu-dbm/prototype_com remove the 'write permission' bit on gdbm.h -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
