Martina, Very quick skip through, see comments below ...
Paul Martina Tomisova wrote: > > I've prepared changes for including gdbm (GNU Database Manager) into Nevada. > There is a webrev so you can check it. Any comments are welcomed. PSARC is > approved 2008/645. > > http://cr.opensolaris.org/~martina/gdbm/ === Start of Comments === 1. usr/src/lib/gdbm/METADATA Remove lines 1 and blank line at the end I think the NAME: line should be more descriptive 2. usr/src/lib/gdbm/Makefile.sfw Change line ... 37 CONFIGURE_OPTIONS += --enable-shared --disable-static --prefix=/usr as you don't need the --prefix= as its the default setting in Makefile.master Change 'all:' rule to .. all: all32 all64 and delete ... 67 real-all: all32 all64 Change the names of the install scripts to use the standard name, ie. install-sfw & install-sfw-64 You could add definition .. TARBALL = $(VER).tar.gz and use that in the '$(VER)/configure:' rule. 3. usr/src/lib/gdbm/gdbm.sunman maybe rename to its standard name form sunman-stability, that way is more obvious what it is. 4. usr/src/lib/gdbm/install-gdbm & usr/src/lib/gdbm/install-gdbm-64 Rename them, see (2) And ... Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and add a $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue). And ... Remove the write permission from files in /usr 5. usr/src/pkgdefs/Makefile put in alphabetical order 6. usr/src/pkgdefs/SUNWgnu-dbm/depend Move the 'Copyright' lines to after the 'CDDL HEADER END' header. 7. usr/src/pkgdefs/SUNWgnu-dbm/pkginfo.tmpl Maybe add the version to the end of the DESC= line, eg. DESC=".......... (n.x.m)" 8. source tarball This is not in your webrev - add so RTIer knows it will be checked-in with the other stuff. 9. usr/src/pkgdefs/SUNWgnu-dbm/prototype_com & usr/src/pkgdefs/SUNWgnu-dbm/prototype_i386 & usr/src/pkgdefs/SUNWgnu-dbm/prototype_sparc Again, remove the write permission from files in /usr === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
