Bruce,

I'll take another look when you have resolved the below ....

paul

Bruce Rothermal wrote:

> 
> Changes posted at http://cr.opensolaris.org/~bruce_r/powerman-2.3/

> 
> On Dec 19, 2008, at 1:33 AM, Paul Cunningham wrote:

>>
>> 1. usr/src/cmd/powerman/METADATA
>>   Add missing field, see ...
>>   http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines

> 
>>   I don't think you need the COMMUNITY: field, its the
>>   same as URL:, see
>>   http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
>>
> Leaving it.

Why when its a duplicate of URL: ?


>>
>>
>> 3. usr/src/cmd/powerman/sunman-stability
>>   Is 'Interface Stability     Volatile' correct?
>>
> Interface is not controlled by Sun so it should be Volatile. 

should you be using "Uncommitted" as most seem to do now?

> Man pages 
> are provided in the tar ball. I am not providing any changes to these. 
> Should I be?
>>   Where is this applied to the man pages ?

The sunman-stability sed script is normally applied to the man pages 
from within install-sfw. There might be another way to apply it though 
if you are not using an install-sfw script - I forget how though, ask 
someone like Norm Jacobs <Norm.Jacobs at Sun.COM>


>>
>>
>> 5. usr/src/pkgdefs/SUNWpowermanr/depend
>>   Does a root package really have these dependencies?
>>
>>   Looks like you have a dependency loop ...
>>     SUNWpowermanr -> SUNWpowermanu -> SUNWpowermanr
>>
> The powerman software has files that install into both usr and etc but 
> they are all needed to be installed on the system. root package will not 
> allow usr files and vice versa. So I have to make them dependent on each 
> other. This shouldn't be a loop because if you install SUNWpowermanr it 
> will indicate that SUNWpowermanu is needed but will not have an issue if 
> it is already installed. Do you know of any issue with this?

SUNWpowermanu depends on SUNWpowermanr but you can't install 
SUNWpowermanr first because it depends on SUNWpowermanu


>>
>> 8. usr/src/pkgdefs/SUNWpowermanu/depend
>>   Have you run the dependency checker script against
>>   your package to ensure you have picked up all its
>>   dependencies?
>>
> Where is this dependency checker script

I think it might be in the gate's tools directory, but there is also 
this ....

Alan Coopersmith wrote:
 > Todd Pisek wrote:
 >> I have heard that scripts/tools exist to help determine
 >> the dependencies
 >> of a new package. Does anyone know where such a thing can
 >> be found and
 >> how it is used?
 >
 > The script I wrote, and which Install QA uses to double check
 > your work,
 > is available on the SWAN at
 > http://xserver.sfbay.sun.com/~alanc/check-deps.pl
 > and attached here for people without SWAN access. (I'd
 > sent out a previous
 > version a while ago, but it was updated in May to add
 > support for the new
 > 7z compression used in the WOS.)
 >
 > To view documentation, run "perldoc -F check-deps.pl" on it.
 >
 > It's far from perfect, but generally detects:
 >  - libraries linked to by ELF binaries
 >  - shells/interpreters listed on #! lines
 >
 > It also finds errors in your ELF binary RUNPATH settings like
 > forgetting -R paths you need, including ones you don't need,
 > forgetting -norunpath on C++ binaries, etc.

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to